Hacker Newsnew | past | comments | ask | show | jobs | submit | aredplug's commentslogin

Even if that were true, is it a bad thing?


I believe a variant of: "It is a well-known fact that those people who must want to rule people are, ipso facto, those least suited to do it... anyone who is capable of getting themselves made President should on no account be allowed to do the job."

... applies to code reviewers.

I like Google's review standard:

"In general, reviewers should favor approving a [PR] once it is in a state where it definitely improves the overall code health of the system being worked on, even if the [PR] isn’t perfect."

https://google.github.io/eng-practices/review/reviewer/stand...


I often approve a PR with the comment "Approved with comments".

In other words, I didn't notice any bugs but I have some suggestions. I'll let you decide if you want to make the changes or not.


+1. The job of reviewer on shared codebases is advisory, not as a gatekeeper.

If people choose to ignore comments, then that's a behavioral issue worth escalating.


I've been in teams where those comments are never addressed because the pressure is on "push something that roughly solves the task so you can show something during demo".


Azul is popular in low latency financial services. A usecase might be to reduce the variance that JIT compilation introduces to transaction latency, especially at the high percentiles.


Think of this as an extension of the build pipeline, which already involves shipping source and build artifacts between multiple machines.


To counter the stories of "an ergonomic keyboard" fixed my health issue...

I had back pain for a few years. After physio and other improvements I tried an Ergodox and that didn't fix it.


https://news.ycombinator.com/item?id=29598697 cites evidence that 94% do the right thing.

Perhaps you're overly cynical?

Either way, a good demonstration of the value of empirical evidence.


There are other things you can't control. Like when NS records for a new domain show up in the servers for the TLD.

I suppose it's reasonable that you could provide a better estimate for new domains and transfers based on past experience and existing TTLs. But it will be an estimate. And the estimates would be individual or sub-group ones, like "estimate for a new .com domain" and "specific estimate for transfer of this domain", etc.


I'm happy to pay and wait for the Librem 5 because they fund a lot of Phosh development.

Keep up the good work!


Perhaps quotes that make people feel bad are less likely to survive.


Just start to feel bad all the time to compensate for this bias, easy!


<sarcasm>Pretty sure that's imposter syndrome<sarcasm>


Because you didn't close that last tag I feel like there is still some double sarcasm coming after this remark...


Hmm. Now I'm wondering if it makes semantic sense to nest sarcasm tags. If not, they might self-close, like <p> or <li>.


</sarcasm></sarcasm>

<i>Felt like I needed to resolve that or we may never stop being sarcastic</i>


Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact

Search: